Add log informing user of intentional delay in job execution#284
Conversation
|
Hi @Bungeefan, Looks good you just need to sign your commits with the |
Signed-off-by: Severin Hamader <severin.hamader@yahoo.de>
lukasdotcom
left a comment
lukasdotcom
left a comment
There was a problem hiding this comment.
Looks Good. I'll look at your other prs later as they will take a little longer to review. 🚀
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
As discussed in #277:
While working on the feature, I discovered that the integration can delay the job execution without any information to the users.
This PR adds a simple log line with information when intentionally delaying the execution of the import job.
Feel free to change the message as you see fit, I just threw something together that had enough information for me while testing.
Off-topic: I also noticed that Nextcloud already provides a scheduling feature for jobs, maybe it would be worth it to switch to the native scheduling instead of manually re-scheduling the job every ~5 minutes.